T3T1 mercury UI - PIN keyboard and flow #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrusvit
requested review from
mmilata
and removed request for
prusnak and
matejcik
|
|
Open
|
Tested on device and it works nicely 👍 |
mmilata
reviewed
May 9, 2024
There was a problem hiding this comment.
Please regenerate fixtures.json (ones that don't fail) and also make sure all screens of the multi-screen flows are covered by device tests. The current copypaste from Model T records only the first screen - this doesn't need to be changed everywhere but the new screens need to be recorded in at least one test case.
|
Please change the X/delete/check buttons according to figma. |
obrusvit
force-pushed
the
obrusvit/ui-t3t1-PIN-keyboard-and-flow
branch
from
9e66f09
to
593a2aa
Compare
mmilata
approved these changes
May 13, 2024
[no changelog]
[no changelog]
Adds SwipeFlow for ConfirmAction or ConfirmActionSimple. Without animation as of now. [no changelog]
obrusvit
force-pushed
the
obrusvit/ui-t3t1-PIN-keyboard-and-flow
branch
from
593a2aa
to
a6ef698
Compare
|
rebased, I will wait for CI to update fixtures, then merge |
[no changelog]
obrusvit
force-pushed
the
obrusvit/ui-t3t1-PIN-keyboard-and-flow
branch
from
a6ef698
to
b1261fc
Compare
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds:
confirm_actiontaken from tap to confirm animation for mercury UI #3805 and modified slightly so that we can confirm also actions without explicit "tap to confirm" or "hold to confirm" but only with simple "swipe up"Some limitations added here for now #3748