Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helper callback stack paths in packaged app #208

Merged
merged 1 commit into from Sep 14, 2023

Conversation

montegoulding
Copy link
Contributor

This patch resolves an error where the registerd key file callback stacks paths are retained from the build and not resolved at runtime for the packaged app. An error is therefore thrown in the packaged app at startup if there is both a callback stackfile and distributed files.

An error will still be thrown if the callback stackfile was not distributed, however, that is a valid error given the registered key files were distributed and they require the callback stackfile.

Closes #202

@montegoulding
Copy link
Contributor Author

@trevordevore if this is merged I no longer need #204 so we could close that if you don't see the need.

This patch resolves an error where the registerd key file callback stacks paths
are retained from the build and not resolved at runtime for the packaged app.
An error is therefore thrown in the packaged app at startup if there is both a
callback stackfile and distributed files.

An error will still be thrown if the callback stackfile was not distributed,
however, that is a valid error given the registered key files were distributed
and they require the callback stackfile.
Copy link
Owner

@trevordevore trevordevore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevordevore trevordevore merged commit 934a63e into trevordevore:develop Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registered file component callback stack not re-resolved in deployed app
2 participants