Process inline tags as HTML blocks when they span multiple lines (#571) #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where inline tags were being wrapped in paragraph tags
|
LGTM thanks! |
|
Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #571.
Sometimes, inline tags (such as
<a>) are written over multiple lines for readability, which makes them look alot like block elements. When spread out over multiple lines, the opening and closing tags would be detected as paragraphs and wrapped in<p>tags, which is invalid.This PR avoids this by hashing these block-like spans to protect them from
_form_paragraphs. The contents of these are run though_run_span_gamutin case there's any markdown in there. Since inline tags shouldn't contain block tags, we don't need to worry about processing any blocks.The list of span tags was taken from here.