Fix bad handling of consecutive bold words (#541) #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will prob do another release after this. |
fghaas
added a commit
to fghaas/python-markdown2
that referenced
this pull request
Dec 11, 2023
Update the changelog in relation to the fix applied in 078f76a (PR trentm#545).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #541 while still protecting against #493.
Whilst attempting to fix a ReDOS, I changed the
_strong_reto use a greedy pattern, which would consume the lengthy ReDOS input without spending too much processing time on it. However, this also caused the_strong_reto consume multiple bold words as one.The fix here is to make the regex non-greedy again.
This should match the opening syntax followed by a non-whitespace char, one or more characters followed by an optional
<em>closer, and then the closing syntax preceeded by a non-whitespace char.