Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks improvements and code simplification #544

Merged
merged 1 commit into from Jan 5, 2024
Merged

Breaks improvements and code simplification #544

merged 1 commit into from Jan 5, 2024

Conversation

m417z
Copy link
Contributor

@m417z m417z commented Dec 9, 2023

  • Using both a newline and a backslash no longer results in two line breaks.
  • Allow to keep using trailing spaces for a line break.
  • Remove redundant trailing space before a line break.

@nicholasserra
Copy link
Collaborator

Looks like some test failures. @Crozzers if you have a sec would love your eyes on this too thanks!

* Using both a newline and a backslash no longer results in two line breaks.
* Allow to keep using trailing spaces for a line break.
* Remove redundant trailing space before a line break.
@m417z
Copy link
Contributor Author

m417z commented Dec 10, 2023

Rebased and fixed WaveDrom tests.

@Crozzers
Copy link
Contributor

LGTM. The removal of if 'breaks' in self.extras threw me for a bit but that looks to be covered in the else clause

@nicholasserra nicholasserra merged commit 1c7902b into trentm:master Jan 5, 2024
18 checks passed
@nicholasserra
Copy link
Collaborator

Thanks!

@m417z m417z deleted the breaks-improvements branch January 6, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants