Repair ReDoS (issue #493, PR #494) #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve merge conflicts, remove lookbehinds from code friendly regexes
|
LGTM thanks! |
|
Hi team, The patch is okay when Unfortunately, the conversion remains slow in the following configuration: I have no suggestion to help more. |
|
My bad, I forgot to apply all the RE changes to both the strong RE and the code friendly strong RE. I'll get a fix for this submitted soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #493 by patching a ReDoS vulnerability in the
<strong>and<em>regexes.Full credit to @DarkTinia for the discovery and for #494, which this PR is based off of. However, this PR negates the need for adding third party regex libraries to the project.
The fix works by removing the lookbehinds from the relevant regular expressions. From my testing, this was sufficient to patch the ReDoS whilst not breaking any test cases.