Fix base64 images being corrupted in safe mode (issue #526) #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #526 by not escaping certain base64 characters in URLs when an image data URL is detected.
It works by adding a step to
_protect_url
that checks if the URL matches the data URL format. The format allows for a MIME type, an optionalbase64
token and then the data. If the MIME type starts withimage/
and thebase64
token is present, then the charset of the URL is assumed to be base64.An additional parameter is then passed to
_hash_escape_url
which skips encoding the+
sign. It's important to note that the charset of the URL isn't validated in any way, so it may contain other characters as well.