Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always restore hashed HTML blocks (issue #185) #521

Merged
merged 3 commits into from Jul 23, 2023

Conversation

Crozzers
Copy link
Contributor

This PR fixes #185 by always restoring hashed html blocks at the end of conversion.

The original markdown snippet was as follows:

<div
>
<h3>Archons of the Colophon</h3>
<p>by Paco Xander Nathan
</p>
</div>

The <p> tag would be hashed by the strict block sub but the enclosing <div\n> would only be caught by the liberal block sub, leading to nested hashes.

Nested hashes don't get fully unravelled in _form_paragraphs, only 1 layer does, so hashes would remain in the text until the end of the conversion process.
Since _unescape_special_chars doesn't process HTML blocks (only special chars and code blocks), the hash would remain in the final output.

What I've done is make sure that _unescape_special_chars also processes HTML blocks when performing its un-hashing.

…onversion.

Nested hashes don't get unravelled in `_form_paragraphs`
@Crozzers Crozzers changed the title Always restore hashed HTML blocks Always restore hashed HTML blocks (issue #185) Jul 22, 2023
@nicholasserra
Copy link
Collaborator

Thank you for your continued work on this issue

@nicholasserra nicholasserra merged commit c18de16 into trentm:master Jul 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with markdown-in-html
2 participants