Always restore hashed HTML blocks (issue #185) #521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #185 by always restoring hashed html blocks at the end of conversion.
The original markdown snippet was as follows:
The
<p>
tag would be hashed by the strict block sub but the enclosing<div\n>
would only be caught by the liberal block sub, leading to nested hashes.Nested hashes don't get fully unravelled in
_form_paragraphs
, only 1 layer does, so hashes would remain in the text until the end of the conversion process.Since
_unescape_special_chars
doesn't process HTML blocks (only special chars and code blocks), the hash would remain in the final output.What I've done is make sure that
_unescape_special_chars
also processes HTML blocks when performing its un-hashing.