Fix relative links not working in safe mode (issue #254) #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copies a url regex from pagedown (used by stackoverflow)
… in favour of link. Project source, copyright notices and link to license are kept but the full MIT text was removed
Crozzers
force-pushed
the
fix-rel-links-in-safe-mode
branch
from
28620bf
to
1e828a0
Compare
Crozzers
force-pushed
the
fix-rel-links-in-safe-mode
branch
from
1e828a0
to
4a46040
Compare
|
LGTM I think that comment block is fine. Thanks! Prob cut a release next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #254 by cherry-picking commit pknowles/python-markdown2@76c663d and adding a test case for this bug.
I removed the full MIT license text from the original commit, keeping the copyright attributions and a link to the license instead.
For such a small snippet of code, I think this approach is sufficient? In-lining is messy and I'm not sure where else the license would be stored.
Happy to hear feedback on this