Fix HTML elements not unhashing correctly (issue 508) #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crozzers
changed the title
| @@ -908,6 +908,10 @@ def _strict_tag_block_sub(self, text, html_tags_re, callback): | |||
|
|
|||
| return result | |||
|
|
|||
| def _tag_is_closed(self, tag_name, text): | |||
| # super basic check if number of open tags == number of closing tags | |||
| return len(re.findall('<%s(?:.*?)>' % tag_name, text)) == len(re.findall('</%s>' % tag_name, text)) | |||
There was a problem hiding this comment.
Wonder if this could be even simpler on the left side, something as simple as even:
len(re.findall('<%s' % tag_name, text)) == len(re.findall('</%s>' % tag_name, text))
which just bails on matching the opening element's end > and middle content.
There was a problem hiding this comment.
I mainly put that there because I was concerned about incomplete tags potentially messing it up. Not sure as to how something like <div> <div </div> should be interpreted
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #508 by patching the close tag detection in the strict block tag hashing function.
The issue was with lines such as:
Where the first opening
<div>tag would be deemed as "closed" because there was a closing</div>tag present on the same line.The fix is to count the number of opening and closing tags on a single line. If they are inequal, the tag is deemed "open".