Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DonateAction to extend TransferAction (instead of TradeAction) #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trentlarson
Copy link
Owner

All the other TradeActions involve a swap of items or an intention of each party both giving something and receiving something in return. (In fact, in broader contexts, there's a phrase that "trade is the origin of most problems", and the concept is distinguished from gifts and donations.) TipAction is another possible difference, but it is done in return for good service... I could see an argument for it either way.

DonateAction seems distinctly different, explicitly "without compensation", so I propose to make it a subclass of TransferAction instead.

@trentlarson
Copy link
Owner Author

trentlarson commented May 22, 2023

There are 3 properties of TradeAction that would be lost: price, priceCurrency, and priceSpecification. One solution for pricing is to make the object be a MonetaryValue or TypeAndQuantityNode -- and if there's already an object then that might be turned into an array (and do we really need priceSpecification?).

@trentlarson
Copy link
Owner Author

I've made this at schema.org: schemaorg#3338

@trentlarson trentlarson reopened this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant