Handle empty commit messages (#7767)

* Handle empty commit messages * Simplify condition
treeverse · May 19, 2024 · c33a166 · c33a166
1 parent dc98f49
commit c33a166
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/webui/src/lib/components/repository/commits.jsx b/webui/src/lib/components/repository/commits.jsx
@@ -126,12 +126,16 @@ const CommitInfo = ({ repo, commit }) => {
   );
 };
 
+export const CommitMessage = ({ commit }) =>
+    commit.message?.length ?
+        <span>{commit.message}</span> : <span className="text-muted">(No commit message)</span>;
+
 export const CommitInfoCard = ({ repo, commit, bare = false }) => {
   const content = (
     <>
         <div className="d-flex">
           <div className="flex-grow-1">
-            <h4>{commit.message}</h4>
+            <h4><CommitMessage commit={commit}/></h4>
           </div>
           <div>
             <CommitActions repo={repo} commit={commit}/>

diff --git a/webui/src/pages/repositories/repository/commits/index.jsx b/webui/src/pages/repositories/repository/commits/index.jsx
@@ -16,6 +16,7 @@ import {
     LinkButton,
     Loading, RefreshButton
 } from "../../../../lib/components/controls";
+import {CommitMessage} from "../../../../lib/components/repository/commits";
 import {useRefs} from "../../../../lib/hooks/repo";
 import {useAPIWithPagination} from "../../../../lib/hooks/api";
 import {Paginator} from "../../../../lib/components/pagination";
@@ -38,7 +39,7 @@ const CommitWidget = ({ repo, commit }) => {
                             pathname: '/repositories/:repoId/commits/:commitId',
                             params: {repoId: repo.id, commitId: commit.id}
                         }}>
-                            {commit.message}
+                            <CommitMessage commit={commit}/>
                         </Link>
                     </h6>
                     <p>