Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include base URL in Faraday.new so it honors no_proxy #684

Merged
merged 2 commits into from
Mar 7, 2018
Merged

Include base URL in Faraday.new so it honors no_proxy #684

merged 2 commits into from
Mar 7, 2018

Conversation

bnferguson
Copy link
Contributor

Currently fixing proxy issues in Enterprise and one of the things we came across is how Faraday won't honor the no_proxy env var if you don't include a base url in the Faraday.new

You can read more about it here:

lostisland/faraday#700
lostisland/faraday#701

The previous PR attempting to fix this is #669.

This is something we'll need to do across all projects. The way you can catch that it's happening is a no_proxy is unsupported in the logs when the no_proxy env var is set.

@bnferguson bnferguson self-assigned this Mar 7, 2018
@bnferguson
Copy link
Contributor Author

A quick survey of projects and it looks like everything else besides tasks has this sorted. We see this tasks issue in API as well but I think that's dead code from when we vendored core.

@bnferguson bnferguson deployed to com-production March 7, 2018 18:34 Active
@bnferguson bnferguson deployed to org-production March 7, 2018 18:35 Active
@bnferguson bnferguson temporarily deployed to travis-api-production March 7, 2018 18:35 Inactive
@bnferguson bnferguson merged commit f0b0c48 into master Mar 7, 2018
@bnferguson bnferguson deleted the bf-include-url-in-faraday-init branch March 7, 2018 18:41
bnferguson added a commit that referenced this pull request Mar 7, 2018
@bnferguson
Include base urls in Faraday.new, otherwise Faraday won't use no_proxy (
c0e88dd 
#684)
@bnferguson bnferguson mentioned this pull request Mar 7, 2018
Merged
bnferguson added a commit that referenced this pull request Mar 7, 2018
@bnferguson
Include base urls in Faraday.new, otherwise Faraday won't use no_proxy (
716e09a 
#684) (#685)
bnferguson added a commit that referenced this pull request Mar 29, 2018
@bnferguson
Include base urls in Faraday.new, otherwise Faraday won't use no_proxy (
f20a9f1 
#684)
@bnferguson bnferguson mentioned this pull request Mar 29, 2018
Merged
bnferguson added a commit that referenced this pull request Mar 29, 2018
@bnferguson
[Enterprise 2.1 Backport] Include base URL in Faraday.new so it honor…
f236021 
…s no_proxy (#684) (#722)

* Include base urls in Faraday.new, otherwise Faraday won't use no_proxy (#684)

* Fix merge conflicts
@Tahsin-travis-ci Tahsin-travis-ci mentioned this pull request Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bnferguson bnferguson

Labels
enterprise-2.1-backport
Projects
None yet
Milestone
No milestone
1 participant
@bnferguson