refactor: harden idle_seconds #6834
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
May 27, 2024
There was a problem hiding this comment.
I'm not sure that I like this.
- It doesn't quite make sense for
queue_stalled_minutes_to be atime_t. - It assumes that
time_tis signed, which is arguably true for POSIX and definitely true for GNU, but isn't guaranteed in the C spec AFAICT - The change seems to be prompted by an invalid assumption in the assertion
now >= latest. Maybeidle_secondsshould returnnow > latest ? now - latest : 0?
ckerr
approved these changes
Jun 1, 2024
ckerr
added
scope:core
type:refactor
… to be signed in the C spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That change wouldn't fix the root cause of #6833, but it would avoid further issues in release by preventing returning a negative idle_seconds.
I see for instance that we read
date_active_from a resume file, so that could be a scenario where date_active_ is above now. Or the system clock was modified.