-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: new tr_variant
API in transmission-remote
and other cleanup
#6798
Open
tearfur
wants to merge
20
commits into
transmission:main
Choose a base branch
from
tearfur:remote-tidy
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
added
scope:remote
scope:core
type:refactor
A code change that neither fixes a bug nor adds a feature
notes:none
Should not be listed in release notes
labels
Apr 18, 2024
nevack
reviewed
Apr 18, 2024
@ckerr Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
notes:none
Should not be listed in release notes
scope:core
scope:remote
type:refactor
A code change that neither fixes a bug nor adds a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to sweep away some of the aging code in
transmission-remote
so that I feel comforatable enough to add sequential download command line options to it.Other than changing some of the percentage displays to show 1-2 decimal points (
strlpercent()
) instead of truncating them all, there are no intended functional changes.