Revert "run peerMgrPeerStats in session thread" (#5992) #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Coeur asking because of your description: does this actually fix 6762? I might be wrong but I think the race condition is there either way & that reverting 5992 just resets so that we can try another fix? |
|
6762 is describing performance regressions. That's what this revert is about: attempting to return to previous performances. @dantearmok am I correctly interpreting your primary issue? |
|
Isn't it a crash report...? Edit: Oh I see where the performance part is. Nonetheless, it is also a crash report. |
|
In the absence of feedback from @dantearmok, I'm de-prioritizing this change. I'll instead look into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #6762