Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save queue order between sessions #6753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tearfur
Copy link
Member

@tearfur tearfur commented Mar 29, 2024

Fixes #155.

Notes: Save upload/download queue order between sessions.

Important: This PR does not load the queue order stored in pre-4.0.0 macOS apps.

The macOS app in Tr 3.00 and below has a feature to save the queue order between sessions, but it got removed in 4.0.0. This PR adds it back in libtransmission for all Tr clients to enjoy.

Need help

It would be nice if someone can write code in the macOS app that loads the queue order from pre-4.0.0 macOS apps. AFAICT, they are stored in Transfers.plist.

@tearfur tearfur added scope:core type:feat A new feature semver:minor adds functionality in a backwards compatible manner labels Mar 29, 2024
@tearfur tearfur added this to the 4.1.0 milestone Mar 29, 2024
@frozenpandaman
Copy link

THANK YOU!!!!!! What a legend. Cannot WAIT for this to get merged & a new release to include it. So deeply appreciate you taking the time to fix this (significant!) issue.

@Coeur
Copy link
Collaborator

Coeur commented Mar 30, 2024

Hi. Can you also prepare a 4.0.x pull request for this? Thank you.

libtransmission/resume.h Outdated Show resolved Hide resolved
@ckerr ckerr added the needs update The PR has needs to be updated by the submitter label Mar 31, 2024
@tearfur tearfur removed the needs update The PR has needs to be updated by the submitter label Apr 1, 2024
@tearfur tearfur requested a review from ckerr April 1, 2024 04:42
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

@Pentaphon
Copy link

Any updates on this highly requested feature? A lot of people are looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:core semver:minor adds functionality in a backwards compatible manner type:feat A new feature
Development

Successfully merging this pull request may close these issues.

feat: save queue order between sessions
6 participants