Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resume file remove redundant have key and other cleanup #6747

Merged
merged 5 commits into from
May 26, 2024
Merged

chore: resume file remove redundant have key and other cleanup #6747

merged 5 commits into from
May 26, 2024

Conversation

tearfur
Copy link
Member

@tearfur tearfur commented Mar 28, 2024 •
edited

Removed the have key in the resume file, which has been redundant for many years. Also cleaned up a bunch of minor issues along the way.

@tearfur tearfur added scope:core type:fix A bug fix notes:none Should not be listed in release notes labels Mar 28, 2024
@tearfur tearfur requested a review from ckerr March 28, 2024 06:35
@tearfur tearfur changed the title fix: don't save blocks bitfield to resume when we are seed perf: don't save blocks bitfield to resume when we are seed Apr 1, 2024
@tearfur tearfur added type:perf A code change that improves performance and removed type:fix A bug fix labels Apr 1, 2024
ckerr
ckerr reviewed Apr 2, 2024
View reviewed changes
libtransmission/resume.cc Outdated Show resolved Hide resolved
libtransmission/resume.cc Outdated Show resolved Hide resolved
@Coeur Coeur requested a review from ckerr April 27, 2024 06:30
@Coeur Coeur mentioned this pull request Apr 27, 2024
Closed
@tearfur tearfur changed the title perf: don't save blocks bitfield to resume when we are seed chore: resume file remove redundant have key and other cleanup May 26, 2024
@tearfur tearfur added type:chore and removed type:perf A code change that improves performance labels May 26, 2024
ckerr
ckerr approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I really like this!

@ckerr ckerr merged commit 3677e7a into transmission:main May 26, 2024
25 checks passed
@tearfur tearfur deleted the resume branch May 27, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
notes:none Should not be listed in release notes scope:core type:chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tearfur @ckerr