Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save queue order between sessions #155

Open
KAMiKAZOW opened this issue Jan 26, 2017 · 66 comments · May be fixed by #6753
Open

feat: save queue order between sessions #155

KAMiKAZOW opened this issue Jan 26, 2017 · 66 comments · May be fixed by #6753

Comments

@KAMiKAZOW
Copy link

When I set up a queue order, then quit Transmission and restart it, the queue is jumbled around.
Tested with both the Qt and GTK clients.

@jemxpat
Copy link

jemxpat commented Jun 23, 2019

This is a massive problem for me, in terms of usability. Is there no way to retain queue order between restarts? How is the queue order determined? Perhaps I can re-write something in the torrent resume files? Some clue, please!

@jemxpat
Copy link

jemxpat commented Jun 23, 2019

What I really want is the ability to assign a label(s) to a torrent and then display via a label pulldown, sort queue by label, etc. Something completely orthogonal to the automated queue order, and entirely controlled by the user.

@carmanaught
Copy link

carmanaught commented Jul 6, 2019

How is the queue order determined?

I'd had a bit of a look into this previously and just re-tested this and as far as I can tell, the queue is restored on resume by loading the files in $XDG_CONFIG_HOME/transmission/resume. The files in the resume directory are named according to the torrent hash (e.g. aec2e48d6ece459f8358aad4889dc83046746b0b.resume is the hash for Fedora-Workstation-Live-x86_64-30) and are loaded in dictionary order (I think that's the right term?), so the order depends upon the hash values.

I would think you'd need to maintain some sort of queue order list based on the torrent hash and compare against the hashes of the torrents to resume to then order the queue, unless the queue order can be stored in the resume file somehow and read from there. I assume some of how it loads the torrent order is based in resume.cc.

Edit: I've been having more of a look at this today and as I understand it resume.cc contains the functions to set/get torrent specific information, such as peers, per-torrent speed limits, etc. It looks like torrent.cc is primarily where that information is actually used.

Rather than trying to manage the queue some separate file, I think it should be possible to store the queue order in the .resume files and then set the queue order when loading the files.

@ahimta
Copy link

ahimta commented Aug 6, 2019

I'm using 2.94 now and it's surprising how this issue hasn't been resolved for years:sweat_smile:. These sorts of bugs are important in the sense that they are very obvious and tangible to users. And although software can never be perfect, having as externally perfect as possible product is a true multiplier:sweat_smile:.

I was planning on fixing this in the past because I was sorting the queue manually and I would rather spend 100x the time productively in fixing a bug than spending 1+ hour on annoying-distracting tasks:sweat_smile:.

However, these days I don't download many torrents and almost never need to sort the queue and would probably rather fix some bugs in other projects are taking away from my time (there's one VLC bug that I plan to work on).

Anyways, the most important thing at this stage is the macro level as to where this issue is in the future of the project. For example, is there an outstanding or planned work that will resolve this or make it easier to resolve.

Otherwise, if there's no related work and only the implementation of the fix is needed, then we need to determine the scope and start working toward a solution.

I haven't looked into this closely but from what @carmanaught mentioned it may be the case that the queue order is just not persisted and from the behavior (can change the queue and everything is reset on restart) and how long this issue has been open (2+ years) this is probably the case:sweat_smile:.

In addition, the 2+ years may indicate that there's some factor why this hasn't been resolved yet and I hope that it's just that the maintainers are busy with something else:sweat_smile:.

So people, let's get going and see this through:smiley:. I think may be able to work on this especially if the maintainers acknowledge this issue and at least provided an outline for the fix:smiley:.

@ckerr ckerr changed the title Queue order forgotten after restart feat: save queue order between sessions Oct 22, 2021
@ckerr ckerr added type:feat A new feature scope:core labels Oct 22, 2021
@beren12
Copy link

beren12 commented Dec 2, 2022

Hasn't os x had this forever? It still has the ability to have torrent groups, but keeping the queue order seems to be broken after 3.x changes. I never noticed 2.x forgetting the order I put my torrents.

@ckerr
Copy link
Member

ckerr commented Feb 9, 2023

Marking this as a regression because starting in 4.0.0 the macOS client uses the same backend settings as the other clients, so now it has this issue as well 🎉

@beninato8

This comment was marked as duplicate.

@mag01
Copy link

mag01 commented Feb 15, 2023

Yup, this is incredibly annoying. There was no such issue at macOS until (I think) some late 2021 - early 2022 nightlies where it started to occur. Since then I was hoping for a fix before the next release, but seeing the 4.0.0 out with this issue still present doesn't give my any hope.

@ckerr
Copy link
Member

ckerr commented Feb 15, 2023

@mag01 maybe reporting it sometime during the four month beta cycle would have helped? 😸

@frozenpandaman
Copy link

Really really hope this will get fixed ASAP.

@pkd81
Copy link

pkd81 commented Apr 17, 2023

Really glad I didn't waste 2 hours of my life on this release re-ordering all my torrents only to have it all wiped out after I rebooted a few days later, like what happened when 4.0.2 was released.

@GaryElshaw
Copy link
Contributor

@pkd81 If you have some skills, please contribute.

@pkd81
Copy link

pkd81 commented Apr 17, 2023

@GaryElshaw raising awareness of this issue is my contribution. Thanks!

@albabe
Copy link

albabe commented Apr 17, 2023

Really glad I didn't waste 2 hours of my life on this release re-ordering all my torrents only to have it all wiped out after I rebooted a few days later, like what happened when 4.0.2 was released.

Really really hope this will get fixed ASAP.

I hope so too. I reordered my torrents 3 times thinking it was just a glitch. Probably 4 or 5 hours.

To: ckerr

This is my first ever complaint to Transmission.. so... sorryt for my ignorance.

@albabe
Copy link

albabe commented Sep 19, 2023

No one knows?

@tearfur
Copy link
Member

tearfur commented Sep 20, 2023

It isn't yet. You can know by that fact that this issue has not yet been closed, nor is it included in the release notes of 4.0.4.

@albabe
Copy link

albabe commented Sep 20, 2023

Hey thanx so much! It seemed like the folks above thought it might be. It's easy to get confused in here. I guess no one but me uses that "Sort by."
I'm glad I didn't try it out because it messes-up the Library file, and you have to resort everything again when you use the older Trans.

@albabe
Copy link

albabe commented Oct 21, 2023

So... this is just not gonna happen? 6 months now. I guess no one uses the "Sort By Cue" but me.

@ckerr
Copy link
Member

ckerr commented Oct 22, 2023

@albabe if you are in a hurry, Transmission is open-source and PRs are welcome

@albabe
Copy link

albabe commented Oct 23, 2023

I assume PR has something to do with Programming? I would, in a second... gladly... but I'm no Programmer. Not even remotely.
I've used Transmission for a very long time. I'm just saddened that I can no longer use it. And, honestly, I'm not really sure I would call waiting 6 months as me being impatient.

@nevack
Copy link
Member

nevack commented Oct 23, 2023

I do not represent the Transmission project, I'm just one of the contributors, and this is my opinion.

@albabe, I understand your frustration and appreciate you speaking about it and bringing attention to the issue.
But all project contributors are volunteers, you are not in a position to demand anything.
All you can hope for is that somebody with 1. skills, 2. will and 3. time will look into this issue.
I think Charles can confirm that many issues were fixed just like that — someone stepped out and did it.
I hope you understand that and will not be turned off by this truth.

@albabe
Copy link

albabe commented Oct 23, 2023

At no point would I make demands of any kind. Why would you even insinuate that? And why would I be "turned off" by a truth? I just can't use the client until it's fixed.

@Pentaphon
Copy link

So... this is just not gonna happen? 6 months now. I guess no one uses the "Sort By Cue" but me.

@albabe you have to understand that this is a volunteer project. Nobody is obligated or paid to take care of any issues. They do it when they feel like it and have the free time to do it. In many projects like this one, an issue may never be fixed. That's just the reality of open source projects. It's ok to come in here and inquire about this issue when it seems overlooked for a long time or to ask if somebody is still interested in an issue when they haven't responded for a long time, but coming in to repeatedly ping people about an issue is simply bothersome and comes off as very entitled. I highly suggest you heed the advice that people are giving you and to leave the issue be after 1 inquiry and just wait to see what happens. Github will ping you when this issue is commented on so you can follow the progress on your own.

Also, if an application is not doing what you want, you need to simply move on to another client that will. That's all you can do for your own needs.

@GaryElshaw
Copy link
Contributor

@albabe I'm building from the main branch and finding it to be stable, i'd recommend moving to the nightlies. https://build.transmissionbt.com/job/trunk-mac/

@Pentaphon
Copy link

Pentaphon commented Dec 7, 2023

@ckerr can we have this and all the https://github.com/transmission/transmission/milestone/14 4.0.x milestones changed to 4.1.0 now that 4.0.5 is out? Doesn't seem like they will ever make it to another 4.0.x release.

@ckerr
Copy link
Member

ckerr commented Dec 8, 2023

@Pentaphon that's what we thought after 4.0.4 as well, so 🤷‍♂️ let's see what happens.

There's still the issue at #5263 (comment). Fixing that would be worth a 4.0.6 release IMO.

@albabe
Copy link

albabe commented Dec 8, 2023

@albabe I'm building from the main branch and finding it to be stable, i'd recommend moving to the nightlies. https://build.transmissionbt.com/job/trunk-mac/

GaryElshaw
Thanx so much for the reply. I really appreciate it<

I have trouble follow this thread. I don't program so I don't even remotely know the vernacular. So forgive me if I seem even denser than I am. So, are you saying the "Sort By Cue" issue has been addressed? I keep my torrents seeding for a long time, sometimes years, so I have a load right now... and I'd really hate to have to take a few hours to reorganize them if the "Que" option doesn't work : )

@GaryElshaw
Copy link
Contributor

@albabe I understand. Entirely up to you, but I think i would still move to the 4.1 branch, even if it is painful at first.

@frozenpandaman
Copy link

I hope it gets included in whatever the next stable release is, whether that is 4.0.6 or 4.1.0. Frankly, I believe this issue being fixed is worth a v4.0.6 release by itself. As I think I mentioned way back when, many places do not allow the use of nightly/unstable/beta clients and thus many users are awaiting any sort of non-nightly release here, whether a minor version, patch, etc.

@frozenpandaman
Copy link

frozenpandaman commented Dec 11, 2023

it's a feature so it's supposed to be in 4.1.0 if we are following semantic versioning.

@Pentaphon It's a bugfix, not a new feature, to my understanding. It's related to a feature that's already already in the program; re-ordering torrents has always been available, or was supposed to be. This is just fixing a bug with the feature which caused the order get scrambled upon dragging, etc. Seems like a patch to me.

@albabe
Copy link

albabe commented Dec 11, 2023

@ Pentaphon rozenpandaman
It's definitely NOT a "New Feature." It was one of the reasons I've been using Transmission for decades.

It's always seemed odd to me that the Transmission folks rarely do updates. I think sometimes it's been Years between Official Builds.
So no word if there will be a 4.1 soon? But from what I'm gleaning here, the "Sort by Que" Feature is working in a recent Nightly Build? And will likely be in 4.1 a "few years" from now? : )

@racemus
Copy link

racemus commented Feb 18, 2024

I'm still using Transmission 3 because when I tried to move to 4th version, my queue order sorting was shuffled. It's still so with 4.0.5 and the yesterday nightly build. As far as I understand, it's connected with this bug.

@albabe
Copy link

albabe commented Feb 18, 2024

@ racemus
Heyz< Same here. It's been almost a year now.
It's an important feature to me, but I assumed since no one has tried to "fix" it since 4 was released, that I was the only one it mattered to.

@albabe
Copy link

albabe commented Mar 27, 2024

So... I guess this "Feature" has been dropped and will no longer be available on Transmission? I guess not very many Users used this?

@Pentaphon
Copy link

So... I guess this "Feature" has been dropped and will no longer be available on Transmission? I guess not very many Users used this?

This is a volunteer project. When somebody has time to add this feature, it will be added or maybe it won't be added because there's nobody to add it. There is no use in asking for it over and over again. The issue is open, there is demand for it as you can see from the thumbs up you got, so it's just a matter of being patient. Your time would be better spent promoting the project elsewhere so people can find it and help work on it.

@albabe
Copy link

albabe commented Mar 28, 2024

Yes... I know. I've read this response from you a few times. I would think there's as little need for you to repeat it as you believe about my comment. Irony might be a factor. And there's no need in being condescending. I've not be mean or condescending to anyone in here.

I didn't notice any "Thumbs."

Unlike your opinion of my comment, I thought my comment might be helpful. Sorry to offend you. I was hoping my comment might remind someone. Obviously this fix is a very low priority.

And: I've been promoting Transmission for what seems like decades.

@tearfur tearfur linked a pull request Mar 29, 2024 that will close this issue
@Pentaphon
Copy link

From the new PR that will fix this issue:

Important: This PR does not load the queue order stored in pre-4.0.0 macOS apps.

The macOS app in Tr 3.00 and below has a feature to save the queue order between sessions, but it got removed in 4.0.0. This PR adds it back in libtransmission for all Tr clients to enjoy.

Need help

It would be nice if someone can write code in the macOS app that loads the queue order from pre-4.0.0 macOS apps. AFAICT, they are stored in Transfers.plist.

Just posting this here in case they don't see that message on the new PR

@albabe
Copy link

albabe commented May 17, 2024

Thanx Pentaphon
Just checking-in. Any word?

@Pentaphon
Copy link

Just checking-in. Any word?

Just follow that PR. Not merged yet.

@albabe
Copy link

albabe commented May 18, 2024

Thanx, but Sorry... I'm at a loss here. There's no hyperlinks in your post, so I see nowhere to go. I don't know what a PR is. And I don't know what is meant by "merged" is this situation.

I went to the link above your comment and I'm not sure what is going on in the thread.

@Pentaphon
Copy link

I don't know what a PR is. And I don't know what is meant by "merged" is this situation.

It sounds like you need to educate yourself on how github works if you want to understand what we are doing here. Please have a look at this and all other Github documentation.

https://docs.github.com/en/get-started/start-your-journey/hello-world

@albabe
Copy link

albabe commented May 19, 2024

Does it really sound that way? Odd, since I'm not a programmer or anything of the sort. I'm just a person who used to use Transmission, who was hoping the nice Volunteers would eventually fix the feature I use.

But thanx for the lofty condescension, rather than an actual answer.

@Pentaphon
Copy link

But thanx for the lofty condescension, rather than an actual answer.

I linked you to a resource that will help you understand what PR and "merged" means. I'm not going to use this issue or spend needless time to type out a whole crash course on Github when you can search that information for yourself. Please educate yourself on how Github works by using my link and gathering your own information. You don't need to be a programmer to be expected to learn the basics of a site you are using. Let's also not flood this issue with bickering. The issue looks like it is being resolved so lets just leave it at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.