Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Snap package for Snapcraft Store #1302

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexhaydock
Copy link

With ref to #1109, I've done some work on putting together a functional Snap package with working GTK2 theming.

I'd be happy to set this up in the Snap store and maintain it if you wanted, but users are more likely to trust a package maintained by the main transgui developers so I'm submitting this PR with working snapcraft.yaml and transgui.desktop file.

Right now it definitely builds fine for the amd64 package and should in theory build fine for i386, but the snapcraft.yaml would need a few tweaks to support the ARM platforms that transgui currently supports.

Let me know if you have any questions.

@alexhaydock
Copy link
Author

Requesting review by @PeterDaveHello, as you seemed invested in the Snap packaging effort over on the issue thread. 👍

@alexhaydock
Copy link
Author

I've packaged up a proof of concept version of this Snap that should be working just fine and ready to install directly from the Snap Store, with strict confinement and full GTK2 theming integration.

I would appreciate feedback and testing from anyone interested, especially users on i386 or armhf platforms.

Get it from the Snap Store

You should be able to install with:

sudo snap install transgui-test

I've committed all the appropriate files to produce the Snap as part of this PR (though unless you're able to successfully retrieve the transgui slug for the project then some minor modifications will be needed). I've published mine under the name transgui-test with the intention of deleting it when the Snap can be maintained upstream with the proper name.

@alexhaydock
Copy link
Author

Hey @alexhaydock,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1cb7cf10-92dc-11ea-84cf-61c3ab5f248b

Looking at the logs of this build failure, it seems to be unrelated to the changes made in this PR.

@PeterDaveHello
Copy link
Member

Sorry for the late reply, let me resolve the conflict first.

@ghost
Copy link

ghost commented May 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@PeterDaveHello
Copy link
Member

Okay, conflict resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants