docs: update @uppy/aws-s3 docs
#5093
Merged
+4
−529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesNo diff |
Murderlon
reviewed
Apr 17, 2024
| @@ -41,7 +41,7 @@ milliseconds on uploading. | |||
|
|
|||
| **In short** | |||
|
|
|||
| - We recommend to set [`shouldUseMultipart`][] to enable multipart uploads only | |||
| - We recommend the default value of [`shouldUseMultipart`][], which enable multipart uploads only | |||
| for large files. | |||
There was a problem hiding this comment.
Suggested change
| for large files. | |
| for large files (100 MiB). |
What about this? |
|
I don't know if it's worth breaking the existing links. In any case, that can always happen in a follow-up PR, but hopefully we can agree this PR is better merged than not |
|
I won't break links on the website, we can ensure that. If people have GitHub files bookmarked I don't care about breaking those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #5076
Refs: #5075
Refs: #5070