Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/core: resolve some (breaking) TODOs #4824

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Dec 14, 2023

Opening as draft so we don't forget about those. It should probably not be merged until Dashboard has been typed

@aduh95 aduh95 added the 4.0 For the 4.0 major version label Dec 14, 2023
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/core/lib/Uppy.js b/packages/@uppy/core/lib/Uppy.js
index 7b7000b..3b2edee 100644
--- a/packages/@uppy/core/lib/Uppy.js
+++ b/packages/@uppy/core/lib/Uppy.js
@@ -304,7 +304,7 @@ export class Uppy {
   resetProgress() {
     const defaultProgress = {
       percentage: 0,
-      bytesUploaded: 0,
+      bytesUploaded: false,
       uploadComplete: false,
       uploadStarted: null,
     };
@@ -1143,7 +1143,7 @@ function _transformFile2(fileDescriptorOrFile) {
     data: file.data,
     progress: {
       percentage: 0,
-      bytesUploaded: 0,
+      bytesUploaded: false,
       bytesTotal: size,
       uploadComplete: false,
       uploadStarted: null,
@@ -1151,7 +1151,7 @@ function _transformFile2(fileDescriptorOrFile) {
     size,
     isGhost: false,
     isRemote: file.isRemote || false,
-    remote: file.remote || "",
+    remote: file.remote,
     preview: file.preview,
   };
 }

@aduh95 aduh95 marked this pull request as ready for review May 15, 2024 14:20
@aduh95 aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label May 15, 2024
@github-actions github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 For the 4.0 major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant