Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed styles of uppy-Webcam-title #4464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changed styles of uppy-Webcam-title #4464

wants to merge 2 commits into from
+2 −1

Conversation

prabureddy
Copy link

As the h1 style of Uppy docs affects the uppy's library h1.uppy-Webcam-title.

#4439

@arturi
Copy link
Contributor

arturi commented May 24, 2023 •
edited by aduh95

Hi! Thanks for the PR. I'd rather handle it differently, probably forgoing the <h1> altogether or using uppy-u-reset class. In most places in Uppy I've purposefully removed semantic typography elements to not conflict with styles on the page.

@arturi arturi self-assigned this Jun 6, 2023
@trabab trabab mentioned this pull request Sep 16, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

Diff output files 
No diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arturi arturi

Labels
pending end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prabureddy @arturi