fix: Problem that Code block is not displayed if even one import fails. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
|
@transitive-bullshit Is this repo still active? Could you add some maintainers? |
|
@mosugi Thanks for this. I noticed the same problem and have cherry-picked your commit into my repo. |
transitive-bullshit
merged commit 7193796
into
transitive-bullshit:main
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promise.all() in Code block fails if even one import process fails, resulting in #477 The problem occurs.
By using Promise.allSettled(), the Code block will be displayed even if it partially fails.
Notion Test Page ID
https://transitive-bs.notion.site/Code-Blocks-0c322c33381c49bca5083a451c334c39