Adding optional custom logo to header with darkmode support #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@si1k is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
theoffbeatdoc
added a commit
to theoffbeatdoc/nextjs-frontend-notion
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to add a logo to the top header. This feature is optional. It also supports using just one logo/image or having different ones for both light and dark mode.
On non-root pages the logo will link to the home page and on the root page the logo is shown without a link. I added
paddingto ensure the logo does not shift when switching between pages and root.Note: It does require
navigationStyle: 'custom'- last commit added this to thesite.config.tscomments.Notion Test Page ID
I have it implemented on my page - https://alexchaveriat.com/