[fixed] Archer could continue stabbing or charging Arrow while attached & [fixed] wrong charge cursor for Knight and Archer while attached #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't take into account PRs merged since the current build yet
mugg91
changed the title
- removed empty lines - removed unused variables - getNet().(...) changed to .(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2024
Fixes #2018
This PR makes fixes to
ArcherLogic.asso Archer won't be able to charge Arrows "in their sleep".It was also possible to press
Action_2to start stabbing a log, quickly start sleeping, and then Archer would fletch an arrow even when not pressing any keys.When getting attached while charging, the cursor frame kept the charging meter. After this PR it will reset to indicate there is no charging.
KnightLogic.aswas changed to fix an issue with the charge cursor having the wrong frame when getting attached while charging.Please note this PR doesn't incorporate other PRs merged in since the current live build 4541. I might try to incorporate that in the future. For now I'm focusing on getting things to work based on the live build.
Please note this PR doesn't fix Knight's double slash bug. For that please see: #1839
Tested in offline and online.