Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Builder block inventory improvements #2002

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Apr 9, 2024

Status

  • IN DEVELOPMENT
  • As explained below, some Locale files still need to be done
  • Add TTH factory entry to Locales

Description

[changed] Builder block inventory will now support more than 12 blocks per page
[changed] Cosmetic changes to Builder block inventory hover text and text/punctuation fixes
[added] Descriptions to component blocks

Fixes #1997

Please see the next posts for more information.

Before

before

After

after

@mugg91
Copy link
Contributor Author

mugg91 commented Apr 11, 2024

Current build in-game look
screen-24-04-11-13-27-21

  • Shows title and description mixed together with \n inside and in two different places
  • Typos and missing punctuation

I'm working on an improvement.
I will try to make the separation line more subtle.
screen-24-04-11-13-23-31

  • Title and description should be two separate strings and should be visibly separate on the hover text.
  • Don't show description in bottom hover text.
  • No \n inside descriptions.
  • Start sentences with a capital letter and end them with a full stop.
  • Working on adding components descriptions.
  • Locale files didn't have trap bridge yet, adding that

@mugg91
Copy link
Contributor Author

mugg91 commented Apr 13, 2024

Added a commit that makes the following changes (which is in line with the announced changes above):

  • BuilderInventory.as changed to support more than 12 blocks per page while setting the minimum number of rows per page to 4. Changed some numbers to make it align with backpack inventory correctly. This change will come in handy when merging with any PRs that introduce more blocks.
  • BuildBlock.as and BuilderInventory.as changed to support a block title separate from its description. Hover text for blocks will work as described in my previous post. I opted against changing the separation line for now.
  • Descriptions to components added.
  • Locale files changed to account for the changes and to add Trap Bridge entry.

Todo:

  • These Locale files still need to be done: Japanese, Polish, Portugese, Russian, Spanish, Turkish

@mugg91 mugg91 changed the title [fixed] Text wasn't aligned properly in Builder's block inventory [fixed] Builder block inventory improvements Apr 13, 2024
@mugg91
Copy link
Contributor Author

mugg91 commented Apr 16, 2024

Added a commit that fixes #1999 .

@mugg91
Copy link
Contributor Author

mugg91 commented Apr 16, 2024

I think this would look best, but I don't think there is markup code within a string to make text get rendered bigger.

(Mockup: )
e

@GoldenGuy
Copy link
Contributor

Would have been great if you could figure out a way to make item icon height centered like this:
image

@mugg91
Copy link
Contributor Author

mugg91 commented Apr 16, 2024

@GoldenGuy
Yes, I would like to fix that but it's not trivial.
These are inventory icons of the material blobs which Requirements.as ready directly by blob name.
Changing inventory icons would be a bad idea since it also shifts the icon up in other places we don't want (such as the inventory grid or the bottom hud).

Requirements.as would need to be changed to support different icons.

Or changes to the string markup could be done to allow setting the image in the location we want, for example:
$icon_name$[align-top]
$icon_name$[align-center]

And changes to the markup could be done to allow changing font size. :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add descriptions to components
2 participants