[fixed] Change class death bug #1970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #1968
When playing online, you could change class by clicking on a button at a respawn point while dying from taking damage.
In TDM, this caused a new blob to be created even though you were already rendered dead and removed from the match.
This PR adds a check to
StandardRespawnCommand.asinonRespawnCommand()to see if the caller has tag"dead"and if he does, it doesn't proceed.After applying this solution, the bug doesn't happen anymore.
Steps to Test or Reproduce
Go to TDM, have the match start.
Be builder and place a ladder above your spawn.
Be low health.
Drop a spike from above you while standing on the ladder and quickly tap the button to change class.
If successful, you will be dead and won't be able to control any character. However, a knight or archer would still spawn and sit idle.
In
on RespawnCommand(), if you useprint("dead? "+caller.hasTag("dead"));, the server-side console would printdead? true.After applying this PR, an idle knight or archer won't get spawned.