-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Td 1166 feedback modal big five assessment #322
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your updates look great! I think we're good until the backend is ready.
The only part I don't love is the awkward margin numbers like $buffer-lg * -16.75 0
. We might want to use flex
to center it. I think that code has been copied down since before there were better ways of centering
Simplified the css rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking good! But another thing we;d still want is some tests. Should just need to mock the assessment and http call and then have it render different questions and submit. Check out some other components for how we've done that in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are almost there! Tests look good, refactor looks good, just a couple tweaks left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking great! Before we merge to master we'll want to:
- Push to staging to run it by Josh
- Bump the version (make sure you bump package.json and then run npm install to bump package-lock.json)
- Make sure the feedback service goes out first
https://paradoxai.atlassian.net/browse/TD-1166