Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex type support in HL dialect #588

Merged
merged 20 commits into from
May 29, 2024
Merged

Complex type support in HL dialect #588

merged 20 commits into from
May 29, 2024

Conversation

Jezurko
Copy link
Collaborator

@Jezurko Jezurko commented May 15, 2024

No description provided.

@Jezurko Jezurko self-assigned this May 15, 2024
@Jezurko Jezurko changed the title Complex Complex type support in HL dialect May 15, 2024
@Jezurko Jezurko linked an issue May 15, 2024 that may be closed by this pull request
Missing support for _Complex #562
Closed
xlauko
xlauko reviewed May 15, 2024
View reviewed changes
include/vast/Dialect/HighLevel/HighLevelOps.td Outdated Show resolved Hide resolved
include/vast/Dialect/HighLevel/HighLevelOps.td Outdated Show resolved Hide resolved
include/vast/Dialect/HighLevel/HighLevelOps.td Outdated Show resolved Hide resolved
include/vast/Dialect/HighLevel/HighLevelOps.td Outdated Show resolved Hide resolved
@Jezurko Jezurko force-pushed the complex branch 2 times, most recently from 0a3e225 to 462e1bd Compare May 16, 2024 12:47
@Jezurko Jezurko marked this pull request as ready for review May 16, 2024 12:49
xlauko
xlauko reviewed May 28, 2024
View reviewed changes
lib/vast/Dialect/HighLevel/HighLevelOps.cpp Outdated Show resolved Hide resolved
test/vast/Dialect/HighLevel/complex-b.c Outdated Show resolved Hide resolved
Jezurko and others added 18 commits May 28, 2024 17:38
@Jezurko
hl: Add complex type.
4fa7f77
@Jezurko
cg: Add complex type visitor.
4064b9b
@Jezurko
hl: Add op for constant with init region.
b48ac9f
@Jezurko
cg: Add visitor for imaginary literal.
b488aef
@Jezurko
hl: Add ops for extraction of imag/real part of complex variable.
3d8bb67
@Jezurko
cg: Implement Unary_ op visitors for Complex statements.
3fd005f
@Jezurko
hl: Extract type verification for float arithmetic to custom verifiers.
9abe4d5
@Jezurko
hl: Cleanup descriptions for new ops.
1dcce7d
@Jezurko
hl: Fix initialized constant attributes and assembly.
a9af4d2
@Jezurko
test: Add test for complex types.
1c335a2
@Jezurko
hl: Reorder arith op definitions.
3ef7466
@Jezurko
hl: Replace type constraints with verifier for fcmp op.
eb91866
@Jezurko
hl: Remove ComplexType from FloatType list.
b217863
@Jezurko
test: Add test for comparison of complex with real.
788c2d8
@Jezurko @xlauko
hl: Fix bracket in ArithBinOp tablegen.
4234b79 
Co-authored-by: Henrich Lauko <henrich.lauko@trailofbits.com>
@Jezurko
hl: Simplify verifier for float compare.
3ac8adb
@Jezurko
test: Expand tests for complex type.
82f4635
@Jezurko
hl: Fix type name in initialized constant op.
0818833
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 3 file(s) not formatted
  • lib/vast/CodeGen/DefaultTypeVisitor.cpp
  • lib/vast/Dialect/HighLevel/HighLevelOps.cpp
  • lib/vast/Dialect/HighLevel/HighLevelTypes.cpp

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 8316d79 into master May 29, 2024
8 checks passed
@xlauko xlauko deleted the complex branch May 29, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees

@Jezurko Jezurko

Labels
high-level llvm-single-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for _Complex
2 participants
@Jezurko @xlauko