Implement stable sorting for events #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #define SORT_CMP(x,y) compare((x).timestamp, (y).timestamp) | ||
| #include "sort/sort.h" | ||
|
|
||
| void events_sort(struct tdb_grouped_event *buf, uint64_t num_events) |
There was a problem hiding this comment.
could you use 4 space indents for consistency with the existing codebase
|
I tested this PR with simple dumps Looks good to me. Thanks @rasky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, TrailDB sorts internal events using libc's
qsortfunction, which is not stable. This means that events with identical timestamp will be reordered, which is especially confusing in case the user is feeding already-sorted data.This patch implements stable sorting through
timsort.NOTE: timsort is potentially very good with pre-sorted data, but we don't get to exploit that because events are being reversed (somewhere in the code coming up to the point being patches). A possible further improvement is to fix this, so that timsort sees pre-sorted data and goes faster.