Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IngressRoute: add an option to disable cross-namespace routing #7595

Merged
merged 12 commits into from Dec 10, 2020
Merged

IngressRoute: add an option to disable cross-namespace routing #7595

merged 12 commits into from Dec 10, 2020

Conversation

rtribotte
Copy link
Member

@rtribotte rtribotte commented Nov 26, 2020 •
edited by kevinpollet

What does this PR do?

This PR adds the allowCrossNamespace option on the Kubernetes provider configuration to allow/disallow cross-namespace routing.
The allowCrossNamespace is defaulted to true.
When set to false it's not possible for an IngressRoute to reference a service in another namespace than its namespace.

Motivation

fixes #7353

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Jean-Baptiste Doumenjou 925513+jbdoumenjou@users.noreply.github.com

@rtribotte rtribotte added this to the 2.3 milestone Nov 26, 2020
@rtribotte rtribotte added this to To review in v2 via automation Nov 26, 2020
jspdown
jspdown requested changes Nov 27, 2020
View reviewed changes
docs/content/providers/kubernetes-crd.md Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
@jspdown
Copy link
Contributor

jspdown commented Nov 27, 2020

@jbdoumenjou, @rtribotte Could you add a new integration test?

SantoDE
SantoDE previously requested changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor stuff :)

jspdown
jspdown requested changes Dec 7, 2020
View reviewed changes
pkg/provider/kubernetes/crd/kubernetes_http.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes_udp.go Outdated Show resolved Hide resolved
@ldez ldez self-requested a review December 7, 2020 11:43
kevinpollet
kevinpollet requested changes Dec 7, 2020
View reviewed changes
docs/content/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/client.go Outdated Show resolved Hide resolved
jbdoumenjou
jbdoumenjou approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jspdown
jspdown approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kevinpollet
kevinpollet approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ldez
ldez approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7ba907f into traefik:v2.3 Dec 10, 2020
v2 automation moved this from To review to Done Dec 10, 2020
@traefiker traefiker mentioned this pull request Dec 10, 2020
Closed
@rtribotte rtribotte deleted the fix-7353 branch February 14, 2022 08:23
@consideRatio consideRatio mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE left review comments

@kevinpollet kevinpollet kevinpollet approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@jspdown jspdown jspdown approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s kind/bug/fix a bug fix size/L
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rtribotte @jspdown @kevinpollet @jbdoumenjou @SantoDE @ldez @traefiker