Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(work in progress) OTT-225-269: Multiple commodity pages bug fix #1904

Merged
merged 5 commits into from May 16, 2024

Conversation

maverickvi
Copy link
Contributor

@maverickvi maverickvi commented May 8, 2024

WIP(work in progress): This ticket requires a total refactor of the sessions code and still needs to be done on Headings, Chapters, Subheadings. I was only able to do Commodities with the limited time I had before going on holiday.

Jira link

https://transformuk.atlassian.net/browse/OTT-225
https://transformuk.atlassian.net/browse/OTT-269

What?

I have added/removed/altered:

  • used request referrer instead of sessions to fix country selection bug
  • pass request referrer as a hidden field to fix date selection bug
  • used request referrer in back links
  • use request referrer in back to commodity links

Why?

I am doing this because:

  • Sessions contained the wrong commodity code
Screenshot 2024-05-08 at 14 03 03

HWallenberg
HWallenberg previously approved these changes May 8, 2024
@maverickvi maverickvi force-pushed the ott-225-multiple-commodity-bug-fix branch from 8918d04 to 7069344 Compare May 10, 2024 08:26
@maverickvi maverickvi changed the title OTT-225: Multiple commodity pages bug fix OTT-225-269: Multiple commodity pages bug fix May 10, 2024
HWallenberg
HWallenberg previously approved these changes May 10, 2024
@maverickvi maverickvi force-pushed the ott-225-multiple-commodity-bug-fix branch from 8ca8691 to 7e23732 Compare May 16, 2024 13:05
@maverickvi maverickvi merged commit d1446b6 into main May 16, 2024
14 of 15 checks passed
@maverickvi maverickvi deleted the ott-225-multiple-commodity-bug-fix branch May 16, 2024 13:10
Copy link

sentry-io bot commented May 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActionView::Template::Error: No route matches {:action=>"show", :controller=>"headings", :id=>"8501535010"}, possible unmatche... GeographicalAreasController#show View Issue
  • ‼️ ActionView::Template::Error: No route matches {:action=>"show", :controller=>"subheadings", :country=>"EG", :id=>"2933599590"}... TradingPartnersController#update View Issue
  • ‼️ ActionView::Template::Error: No route matches {:action=>"show", :controller=>"subheadings", :id=>"8424499000", :measure_type_i... MeasureTypes::PreferenceCodesController#show View Issue
  • ‼️ ActionView::Template::Error: No route matches {:action=>"show", :controller=>"subheadings", :id=>"6404199000"}, possible unmat... GeographicalAreasController#show View Issue
  • ‼️ ActionView::Template::Error: No route matches {:action=>"show", :controller=>"headings", :id=>"6301100000", :measure_type_id=>... MeasureTypes::PreferenceCodesController#show View Issue

Did you find this useful? React with a 👍 or 👎

@maverickvi maverickvi changed the title OTT-225-269: Multiple commodity pages bug fix WIP(work in progress) OTT-225-269: Multiple commodity pages bug fix May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants