HOTT-4532 Remove tabkey submission of search box #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly simplifies search input event handling * Avoids trying to parse the `q` query param value out of the html accessible option content which is always going to be error prone at best * Also removes several race conditions with change events occurring after submit events, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
HOTT-4532
What?
I have added/removed/altered:
Why?
I am doing this because:
This approach avoids trying to parse the
qquery param value out of the html accessible option content which is always going to be error prone at bestThis removes several race conditions with change events occurring after submit events, multiple submit events firing etc
This greatly simplifies search input event handling
Avoids trying to parse the
qquery param value out of the html accessible option content which is always going to be error prone at bestAlso removes several race conditions with change events occurring after submit events, etc
Have you? (optional)
Deployment risks (optional)