HOTT-4467: Add CSP policy to Duty Calculator app #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebw
previously approved these changes
Dec 7, 2023
| @@ -1,5 +1,5 @@ | |||
| Rails.application.routes.draw do | |||
| root to: proc { [404, {}, ['Not found.']] } | |||
| root to: proc { [404, {'Content-Type' => 'text/html'}, ['Not found.']] } | |||
There was a problem hiding this comment.
This could be 'text/plain' ? Its not actually HTML?
There was a problem hiding this comment.
by default it is 'text/plain', but then it adds an inline style at some point, there is no style added and no csp issue either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
HOTT-4467
What?
I have added/removed/altered:
Why?
I am doing this because:
We should add a content security policy to reduce the risk of XSS problems in the sites
Have you? (optional)
Deployment risks (optional)