Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTT-2989: Handle excise additional codes #620

Merged
merged 2 commits into from Apr 6, 2023

Conversation

willfish
Copy link
Member

@willfish willfish commented Apr 6, 2023

Jira link

https://transformuk.atlassian.net/browse/HOTT-2989

image

What?

I have added/removed/altered:

  • Use a compatible multipart-post
  • Handle excise additional codes
  • Verify that excise additional codes are being picked

Why?

I am doing this because:

  • This was missed as part of the broken additional code work

@@ -202,7 +202,7 @@ GEM
mini_portile2 (2.8.1)
minitest (5.18.0)
msgpack (1.7.0)
multipart-post (2.3.0)
multipart-post (2.2.3)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This minor version change completely alters the require structure of the gem so breaks its faraday integration

@willfish willfish force-pushed the HOTT-2989-excise-additional-codes branch from aee204e to 0736a90 Compare April 6, 2023 11:37
@willfish willfish force-pushed the HOTT-2989-excise-additional-codes branch from 0736a90 to 2cdbcd4 Compare April 6, 2023 11:39
@willfish willfish merged commit 3424363 into main Apr 6, 2023
3 checks passed
@willfish willfish deleted the HOTT-2989-excise-additional-codes branch April 6, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants