Skip to content

Commit

Permalink
Merge pull request #621 from trade-tariff/HOTT-2989-xi-additional-codes
Browse files Browse the repository at this point in the history
HOTT-2989: Fixes issue with source of additional code
  • Loading branch information
willfish committed Apr 6, 2023
2 parents 3424363 + 755d75e commit 669def6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/models/api/commodity.rb
Expand Up @@ -103,7 +103,7 @@ def additional_code_measures
answer = if measure.measure_type.excise?
"X#{user_session.excise_additional_code_for(measure.measure_type.id)}"
else
user_session.additional_code_for(measure.measure_type.id)
user_session.additional_code_for(measure.measure_type.id, source)
end

code = measure.additional_code.presence&.code || 'none'
Expand Down
4 changes: 2 additions & 2 deletions spec/models/api/commodity_spec.rb
Expand Up @@ -142,12 +142,12 @@
end

context 'when there are additional code answers on the session' do
let(:commodity) { build(:commodity, :with_none_additional_code_measures) }
let(:commodity) { build(:commodity, :with_none_additional_code_measures, source: 'xi') }

let(:user_session) do
build(
:user_session,
additional_code: { 'uk' => { '103' => picked_additional_code } },
additional_code: { 'xi' => { '103' => picked_additional_code } },
excise: { '306' => '419' },
)
end
Expand Down

0 comments on commit 669def6

Please sign in to comment.