Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL-365: Use exempting_certificate_override table to control whether a certificate is treated as an exemption #1864

Merged
merged 3 commits into from May 13, 2024
Merged

GL-365: Use exempting_certificate_override table to control whether a certificate is treated as an exemption #1864

merged 3 commits into from May 13, 2024

Conversation

rasikasri
Copy link
Contributor

Jira link

GL-365

What?

I have added/removed/altered:

  • Changed GL permutation calculator to check exempting_certificate_override table to detemine if certificate is an exemption
  • Changed GL Category Assessment presenter to check exempting_certificate_override to load exemption certificates

Why?

I am doing this because:

  • We want to override the default exemption behaviour of certificates.

jebw
jebw approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from GL-366 to GL-364 May 13, 2024 17:59
@rasikasri rasikasri merged commit 6897ce8 into GL-364 May 13, 2024
14 checks passed
@rasikasri rasikasri deleted the GL-365 branch May 13, 2024 18:42
rasikasri added a commit that referenced this pull request May 14, 2024
@rasikasri
GL-364: Add model for exemption overrides, possibly should 'relate' t…
44f3680 
…o certificates model (#1844)

* GL-364: Add model for exemption overrides, possibly should 'relate' to certificates model

* GL-366: Add admin APIs to list out a page of overrides

* GL-365: Use exempting_certificate_override table to control whether a certificate is treated as an exemption (#1864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jebw jebw jebw approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@rasikasri @jebw