Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL-364: Add model for exemption overrides, possibly should 'relate' to certificates model #1844

Merged
merged 13 commits into from May 14, 2024
Merged

GL-364: Add model for exemption overrides, possibly should 'relate' to certificates model #1844

merged 13 commits into from May 14, 2024

Conversation

rasikasri
Copy link
Contributor

Jira link

GL-364

What?

I have added/removed/altered:

  • Added GreenLane::ExemptingCertificateOverride model
  • Associate it with Certificate model

Why?

I am doing this because:

  • This model represents certificates that included exemption or excluded exemption, exception to its default behaviour

jebw
jebw requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you add a relationship back from the certificate to the override class

When this is getting loaded in it'll be chaining through from the certificate to the override rather than vice versa

Base automatically changed from GL-363 to main May 2, 2024 15:21
@rasikasri
Copy link
Contributor Author

Looks good but can you add a relationship back from the certificate to the override class

When this is getting loaded in it'll be chaining through from the certificate to the override rather than vice versa

I added the relationship now

jebw
jebw previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rasikasri
GL-366: Add admin APIs to list out a page of overrides (#1850)
6e26a40 
* GL-366: Add admin APIs to list out a page of overrides
rasikasri and others added 4 commits May 13, 2024 19:00
@rasikasri
Merge branch 'main' into GL-364
ee8201d
@rasikasri
GL-365: Use exempting_certificate_override table to control whether a…
6897ce8 
… certificate is treated as an exemption (#1864)

* GL-365: Use exempting_certificate_override table to control whether a certificate is treated as an exemption
@rasikasri
Fix double validation
8a4aeeb
@rasikasri
Fix double validation
86835a3
alexdesi
alexdesi approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@alexdesi alexdesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@rasikasri rasikasri merged commit 44f3680 into main May 14, 2024
11 of 12 checks passed
@rasikasri rasikasri deleted the GL-364 branch May 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdesi alexdesi alexdesi approved these changes

@jebw jebw jebw left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@rasikasri @jebw @alexdesi