Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL-358 Add tables for GreenLanes custom measures #1837

Merged
merged 1 commit into from May 21, 2024
Merged

GL-358 Add tables for GreenLanes custom measures #1837

merged 1 commit into from May 21, 2024

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Apr 25, 2024 •
edited

Jira link

GL-358

What?

I have added/removed/altered:

  • Added table to join category assessments to goods_nomenclatures (called green lanes measures, or pseudo measures)
  • Added table to hold custom exemptions for green lanes
  • Added join table to link custom exemptions directly to category assessments

Why?

I am doing this because:

  • We need the ability to apply category assessements to specific goods_nomenclatures - referred to as green lanes measures
  • We need the ability to annotate the tariff data by assigning custom exemptions to existing measures
  • We need the ability to annotate the tariff data by assigning custom exemptions to green lanes measures

Deployment risks (optional)

  • Some, makes a database schema change

@jebw jebw mentioned this pull request Apr 25, 2024
Closed
5 tasks
@jebw jebw force-pushed the GL-358-add-pseudo-measures-tables branch from ae1d2ce to 4095c49 Compare April 25, 2024 16:17
@jebw jebw force-pushed the GL-358-add-pseudo-measures-tables branch from 4095c49 to 28120e0 Compare May 9, 2024 10:56
@jebw jebw marked this pull request as ready for review May 9, 2024 11:06
alexdesi
alexdesi reviewed May 9, 2024
View reviewed changes
db/migrate/20240507140515_add_green_lanes_measures_tables.rb
Comment on lines +23 to +25
create_join_table({ category_assessment_id: :green_lanes_category_assessments,
exemption_id: :green_lanes_exemptions },
name: :green_lanes_category_assessments_exemptions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better indentation?
I thought the name of the option was table_name, but I can see it works anyway 🤷‍♂️

alexdesi
alexdesi approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@alexdesi alexdesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good,
just a minor comment

@jebw jebw merged commit 3c4010b into main May 21, 2024
14 checks passed
@jebw jebw deleted the GL-358-add-pseudo-measures-tables branch May 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdesi alexdesi alexdesi approved these changes

@rasikasri rasikasri rasikasri approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@jebw @alexdesi @rasikasri