OTT-180 Use router to parse routes #1832
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrectly formatted requests now return a 404
jebw
force-pushed
the
OTT-180-exchange-rates-routing-rules
branch
from
badb490
to
4cc9f09
Compare
willfish
reviewed
Apr 22, 2024
| get 'files/(:type)_:year-:month', to: 'files#show', | ||
| as: :file, | ||
| constraints: { | ||
| type: ExchangeRateFile.type_check_regexp, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrectly formatted requests now return a 404
Jira link
OTT-180
What?
I have added/removed/altered:
Why?
I am doing this because:
:id's were being passed to the controller but then could not be parsed because they did not follow the expected formatDeployment risks (optional)