Add validation from wrong period type for the exchange rates + other improv. #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactor or files_controller. Rename type to period_type for clarity.
alexdesi
commented
Feb 12, 2024
|
|
||
| it 'returns HTTP 400 bad request' do | ||
| expect(response).to have_http_status(:bad_request) | ||
| end |
There was a problem hiding this comment.
This is the new behaviour that has been added.
When the period_type is wrong, it returns bad request 400.
alexdesi
commented
Feb 12, 2024
| filename = ExchangeRateFile.filename_for_download(type, format, year, month) | ||
| validate_params! | ||
|
|
||
| filename = ExchangeRateFile.filename_for_download(period_type, format, year, month) |
There was a problem hiding this comment.
renamed type -> period_type, for clarity.
alexdesi
commented
Feb 12, 2024
| period_year: year, | ||
| period_month: month, | ||
| format: format.to_s, | ||
| ).take | ||
| end | ||
|
|
||
| def validate_params! | ||
| if period_type.nil? # && ExchangeRateFile::APPLICABLE_TYPES.include?(period_type) |
There was a problem hiding this comment.
need to remove this comment.
alexdesi
commented
Feb 12, 2024
| def type | ||
| match_data = id.match(/^(monthly_csv_hmrc|monthly_csv|monthly_xml|average_csv|spot_csv)_/) | ||
| def period_type | ||
| regexp = Regexp.new("^(#{ExchangeRateFile::APPLICABLE_TYPES.join('|')})_") |
There was a problem hiding this comment.
I am reusing the Const here so we avoid data duplication (model-controller)
alexdesi
commented
Feb 12, 2024
| def applicable_types | ||
| where(type: APPLICABLE_TYPES) | ||
| end | ||
|
|
|
Now, we a clear error message when period type is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://transformuk.atlassian.net/browse/HOTT-4894
What?
Why?
To improve error messages and error status.
Make the code cleaner.