New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle Packing #117
base: master
Are you sure you want to change the base?
Circle Packing #117
Conversation
Thanks Xinli. A quick question: does this include treemap? Also, can you include in the PR body a GIF of the template so that everyone knows what it looks like? I find this website to be useful to upload gifs generate external links: https://giphy.com/ In any case, we need to find some time to sit down and have all these three templates merged (pie, treemap, circle packing, anything else?) |
feature request: add option to opt out breadcrumb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Xinli. See my inline comments.
Sorry that there are a lot, but majority of them are minor/my questions.
Can you also check that your Java line endings are correct. It seems like some of them are using CRLF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two additional comments
@@ -0,0 +1,79 @@ | |||
package project; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: test if this can be moved to an indexer file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nashorn failed even though PackNode
is in the same file. Seems that Nashorn only supports public classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one way is not passing ArrayList<PackNode>
into nashorn...
Serialize packnode
s to string before hand, then deserialize in packSib
...
Circle Packing
list of modifications:
this is a demo using the word frequency data set:
This is the first pull request of hierarchical templates, and it was derived from a very old code base, many files have been changed. Thank you for any comments, criticism and discussion!