Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle to 8.5 for support building with java 21 #5295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DinithHerath
Copy link

@DinithHerath DinithHerath commented Apr 9, 2024

Hi @tananaev

  • In the current configuration of the release build, java 21 is used to build the traccar distribution.
  • In the gradle properties, we are still using the gradle-7.5.1-bin.zip as the gradle distribution.
  • According to [1] and [2] gradle 7.5.1 only supports java 18 and this may result in failed builds for java 21.
  • Therefore this PR updates the gradle to 8.5 which is the java 21 supported gradle distribution as per [1] and [3].

[1] https://docs.gradle.org/current/userguide/compatibility.html
[2] https://docs.gradle.org/7.5.1/release-notes.html?_gl=1*1jz7vqz*_ga*MTYwMjA0Mjg3LjE3MTI2MDU4NDc.*_ga_7W7NC6YNPT*MTcxMjYzNDY4OC4zLjEuMTcxMjYzNDc3Mi40Ny4wLjA.
[3] https://docs.gradle.org/8.5/release-notes.html?_gl=1*14d4mdc*_ga*MTYwMjA0Mjg3LjE3MTI2MDU4NDc.*_ga_7W7NC6YNPT*MTcxMjYzNDY4OC4zLjEuMTcxMjYzNDk1OC42MC4wLjA.

Thanks,
Dinith

@tananaev
Copy link
Member

tananaev commented Apr 9, 2024

Looks like CI is failing.

@DinithHerath
Copy link
Author

Looks like CI is failing.

This is due to the usage of the --warning-mode=fail flag in the gradle build command in the CI action. There are a couple of warnings with deprecation notices in the build process. If possible we can ignore this flag and build.

@tananaev
Copy link
Member

tananaev commented Apr 9, 2024

No, ideally we fix the warnings.

@DinithHerath
Copy link
Author

I just checked the warnings, seems like we need to rewrite the build gradle file as there are lot of deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants