Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DatabaseStorage support pagination #5208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbrvalerio
Copy link

This PR adds pagination capability on the DatabaseStorage and the correct handlers on the Request class.
Also removes the Order.limit in favor of the new Pagination.limit and fix the usage of the class throughout the app.

@tananaev
Copy link
Member

So, which databases have you tested and is the syntax an SQL standard?

@gbrvalerio
Copy link
Author

yes, the syntax is SQL standard (OFFSET/LIMIT).

I've tested on PGSQL and H2. Yet to validate on MS SQL

@tananaev
Copy link
Member

Please provide a link to the SQL standard with this.

And let me know once you test everything.

@gbrvalerio
Copy link
Author

PGSQL
"For compatibility with PostgreSQL, MySQL also supports the LIMIT row_count OFFSET offset syntax." ...

the first definition appears on the SQL:2011 spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants