(Bugfix-T800X Protocol) fix battery and power params #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem
The messages for
TLW2 devicesthat use header0x2525don't correctly show thepowerparam.The solution
According to the attached documents, we have reviewed all headers and correct the
powerandbatteryparams.notes:
PR Checklist
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
References
Traccar Forums - Functionality Issues with the Topflytech T880X Protocol on Various Devices (e.g., TLW2-12BL)
TOPFLYtech 0x250x25 Protocol 2023-09-21 (TLW2, PioneerX 100)
TOPFLYTECH 0x250x25 Protocol 2021-12-22 (TLW1, TLD1-A or E, TLD2-L)
TOPFLYtech 0x270x27 Protocol 2023-07-28 ( TLP1_TLP2_SolarGuardX _KnightX & WarriorX )
TOPFLYtech 0x260x26 Protocol 2023-08-02 (TorchX 100, TLD2-D, TLD1-DA or DE)
Credits
Jaime Duardo - Hardware Engineer
Abdelrahman Mousa - Software Engineer