Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionForwarderUrl Added batteryLevel and charge. #5135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellenthal
Copy link

Data as batteryLevel and charge are also important information to forward.

Those are also supported by the OsmAnd protocol (batt and charge).

Data as batteryLevel and charge are also important imformation to forward.
@tananaev
Copy link
Member

I don't think hardcoding all the possible attributes is the way to go. If you really want to implement separate attributes, I think the right way is to refactor the formatting to check for attributes based on the template key.

@hellenthal
Copy link
Author

I agree with that not all possible attributes are the way to go.

I use the forwarding to send tracker data from one traccar server to another traccar server (my home server to a friends home server) by the OsmAnd protocol.

And battery level and charge are also one of the only attributes that are left that is supported by the OsmAnd protocol and not in the PositionForwarderUrl.

After battery level and charge is think only hdop not supported in the PositionForwarderUrl.

@tananaev
Copy link
Member

So do you plan to refactor with my suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants