Aquila Protocol Decoder - OBD Device Support #4892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Jul 13, 2022
src/test/java/org/traccar/protocol/AquilaProtocolDecoderTest.java
Outdated
Show resolved
Hide resolved
tananaev
reviewed
Jul 13, 2022
| @@ -49,6 +49,9 @@ public void testDecodeA() throws Exception { | |||
| verifyPosition(decoder, text( | |||
| "$$CLIENT_1WP,141216511,3,12.963212,77.533989,150908164041,V,31,0,0,0,8,0,0,0,0,0,0,0,1,0,1,0,0,1,0,0,0,0,1,0,0,0,0,0,0,0,0,0,0,1,1,1,0,*2A")); | |||
|
|
|||
| // OBD Device | |||
| verifyPosition(decoder, text( | |||
| "$$CLIENT_1NS,866897057843486,1,13.144755,80.221474,220712112403,A,26,13,907034,263,15,0.830000,0,0,0,526336,13437,4004,3,21,1|010C:06410C14080000|010D:06410D03000000|0104:064104ED000000|010F:06410F6F000000|011F:06411F00050000|0121:06412100000000|0130:0641300D000000|0142:06414233CD0000|0131:06413103F30000|0143:067F43FFFF0000|015C:067F5CFF000000|012F:067F2FFF000000|0110:0641100C470000|0102:067F02FFFF0000|*5A")); | |||
There was a problem hiding this comment.
Another small comment - please check an actual attribute to verify that OBD was decoded. And add a new line below.
There was a problem hiding this comment.
Removed the comment and added a new line below.
I'm not sure how to check an actual attribute to verify that OBD was decoded.
Please point me to an example within another protocol from which I can know how to do this. Thank you.
There was a problem hiding this comment.
You can look at other decoder tests for examples. Like this one:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR targets adding support for OBD device model using the aquila protocol.
Device seller website page:
https://www.itriangle.in/aquila-hardware-board-diagnostics-obd-ii.html
Please find attached the protocol manual for the device.
OBD 2_Protocol Manual.pdf
If this PR is accepted, please add a new device to the traccar.org supported devices list:
Device - "OBD II - 2G" | Protocol - aquila | Port - 5089
Hope this addition helps other traccar users and I thank the creators and maintainers of this wonderful project for making it open source.