Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit casting from decimal to integer #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkWalter94
Copy link

Fixed error with mysql 8.0.36 and trac 1.6 with python 3.10.12 TypeError: 'decimal.Decimal' object cannot be interpreted as an integer

Fixed error with mysql 8.0.36 and trac 1.6 with python 3.10.12
TypeError: 'decimal.Decimal' object cannot be interpreted as an integer
@stoecker
Copy link
Contributor

I don't like that fix much. It makes an already ugly code more ugly. Rather than the casting the time variables in SQL it should be converted to the typical new higher precision trac timing variables everywhere and the SQL then use these everywhere (any only multiply/divide where really necessary).

It's a leftover from older times, where trac stored times in seconds and not micro seconds.

I removed the old trac related code, but didn't want to touch too much at the time I updated for 1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants