Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to comments on changesets #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebDieBln
Copy link

HTML-links to comments on changesets are broken, because they don't use the repository name. So they only work in a setup where a default repository is defined and it is the only one receiving comments.

2023-08-27 18:24:48,193 Trac[main] WARNING: [172.17.0.1] HTTPInternalServerError:
500 Trac Error (No repository specified and no default repository configured.),
<RequestWithSession "GET '/changeset/1dd1c23fc747af84d63d634d61f3eebd3c9cdb84?codecomment=3'">,
referrer 'http://127.0.0.1:30443/changeset/1dd1c23fc747af84d63d634d61f3eebd3c9cdb84/SomeRepo'

(Note the repository name SomeRepo in the referrer but it is missing in the request.)

This PR modifies the generation of hyperlinks in a way that the link always contains the repository name.

The mentioned links can be found in the list of code-comments and on top of each comment itself.

Note that for comments on changesets the repository name is saved in the database field 'path'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant